Change in ovirt-engine[master]: core: translate vm graphic settings in specParams
Omer Frenkel has submitted this change and it was merged.
Change subject: core: translate vm graphic settings in specParams
......................................................................
core: translate vm graphic settings in specParams
When Engine is sending the new-style graphic devices,
VDSM expects the parameters
'fileTransferEnable' and 'copyPasteEnable'
to be sent into the device specParams.
The backward compatibility on VDSM side works when
graphics devices aren't specified, and in this case
and in this case only the vm-level parameters are considered.
Until the UI settings will change directly the per-device
specParams, the best way forward is to translate the per-vm
settings into per-device specParams (format and naming is
the same).
Related-To: https://bugzilla.redhat.com/983019
Change-Id: I960bdee2f0828bd3e34f2e2ba8c169b8b83c8d9a
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
2 files changed, 48 insertions(+), 15 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44313
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I960bdee2f0828bd3e34f2e2ba8c169b8b83c8d9a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org