Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Version cleanup ...................................................................... engine: Version cleanup - replaced String concatenation with StringBuilder - replaced reference comparison with strings to StringBuilder length check - refactored the version component addition to a new method appendVersionComponent Change-Id: I7dba498fa54bae997d08e7457dd53eb60a740199 Signed-off-by: Laszlo Hornyak <lhornyak@redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 1 file changed, 16 insertions(+), 10 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dba498fa54bae997d08e7457dd53eb60a740199 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>