Change in ovirt-engine[master]: core: ValidationResult private default constructor
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ValidationResult private default constructor
......................................................................
core: ValidationResult private default constructor
ValidationResult's default constructor should be private (according to
its javadoc), and valid results should be referenced via the constant
ValidationResult.VALID. Most occurrences in the code adhere to this
rule, except for a single occurrence in AddDiskToVmCommandTest.
This patch returns the default constructor to its intended private state
and fixes the faulty usage in AddDiskToVmCommandTest.
Change-Id: I7afa82aa1ec489b52da78b97b91c2a48eefb8b5f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7afa82aa1ec489b52da78b97b91c2a48eefb8b5f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>