Change in ovirt-engine[master]: core: Fix AddVm faulty storage allocation checks
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix AddVm faulty storage allocation checks
......................................................................
core: Fix AddVm faulty storage allocation checks
Fix AddVmCommand and its descendants storage allocation checks.
Amended and added relevant tests.
Note that the tests here rely on the fact that StorageDomainValidator is
well tested, and only simulate its output, then testing the commands
according to it.
Change-Id: Iff4ad246934b3b94f21ae602067033347c913780
Bug-Url: https://bugzilla.redhat.com/917682
Bug-Url: https://bugzilla.redhat.com/1053742
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommandTest.java
6 files changed, 313 insertions(+), 53 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff4ad246934b3b94f21ae602067033347c913780
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server