Change in ovirt-engine-sdk-java[master]: codegen: Use explicit version of XJC
Juan Hernandez has submitted this change and it was merged.
Change subject: codegen: Use explicit version of XJC
......................................................................
codegen: Use explicit version of XJC
The code generator uses the XJC compiler included in the JDK used to run
it. This means that the version of the compiler may be different and it
may produce different results. This is in particular true for the
versions of the XJC compiler included with Java 7 and Java 8. The
changes from version to version aren't usually problematic, but anyhow
they make it difficult to compare versions of the generated code,
because there is no certainty that the differences are real or just
quirks of the XJC compiler. To reduce the chances of this happening this
patch replaces the call to the external "xjc" command with the call to
the XJC class of a specific version managed by Maven.
Change-Id: I26984881cb68b5dca2a12d5976df80253c65abb1
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M ovirt-engine-sdk-java-codegen/pom.xml
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java
D
ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/common/AbstractCodegen.java
D
ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/common/ICodegen.java
M
ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/ApiCodegen.java
M
ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java
M
ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/AbstractTemplate.java
M
ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/VariableTemplate
A
ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/ClassUtils.java
D
ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/OsUtil.java
M
ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/xsd/XsdCodegen.java
11 files changed, 136 insertions(+), 417 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37781
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26984881cb68b5dca2a12d5976df80253c65abb1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org