Change in ovirt-engine[master]: core: ImportVm cleanup: action and type params
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImportVm cleanup: action and type params
......................................................................
core: ImportVm cleanup: action and type params
The $action and $type params were set in canDoAction_afterCloneVm, which
caused them to be empty if the command failed during
canDoAction_beforeCloneVm.
This patch moves them to the setActionMessagesParameters() method, so
they are set if any failure occurred, regardless of its stage.
Change-Id: I9b3148cd54146ac0b90924464cd27fb54160889b
Bug-Url: https://bugzilla.redhat.com/885459
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9620
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b3148cd54146ac0b90924464cd27fb54160889b
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>