Juan Hernandez has submitted this change and it was merged. Change subject: Use "Action" type ...................................................................... Use "Action" type Currently when the SDK needs to perform an action, like starting a virtual machine, the corresponding service class generates directly the "<action>...</action>" XML text, and it doesn't extract the output parameters of some actions. This patch changes it so that instead of generating directly the XML text it creates an instance of the "Action" struct, populates it, and then generates the XML text using the "ActionWriter" class. In also modifies the SDK so that it takes the returned action and extracts the output parameters. Change-Id: If2e254cf2b89baa91aaa13a058274a0c0c6b02a0 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/lib/ovirtsdk4/service.rb M sdk/spec/spec_helper.rb A sdk/spec/storage_domain_service_spec.rb A sdk/spec/vm_service_spec.rb 5 files changed, 121 insertions(+), 47 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56737 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2e254cf2b89baa91aaa13a058274a0c0c6b02a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>