Tal Nisan has submitted this change and it was merged. Change subject: core: AddAffinityGroupCommandTest @Spy annotation ...................................................................... core: AddAffinityGroupCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to use injected mocks instead of explicitly spying their return. Note that as the order of execution between @Mock and @Spy can't be relied upon the parameters objects was converted from a mock to a real instance. As this object is a simple data-POJO, there is no real reason to mock it anyway, and doing so just adds complexity to the test. Change-Id: I0daa7eedb9b63fa78e8eb11a12e43bc705e4165c Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/commands/AddAffinityGroupCommandTest.java 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0daa7eedb9b63fa78e8eb11a12e43bc705e4165c Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>