From Liron Aravot <laravot@redhat.com>:
Liron Aravot has submitted this change and it was merged. Change subject: core: StorageHandlingCommandBase - getEntitiesFromStorageOvfDisk() loop ...................................................................... core: StorageHandlingCommandBase - getEntitiesFromStorageOvfDisk() loop getEntitiesFromStorageOvfDisk() will enter infinte loop if the ovfStoreDiskImages list contains only not updated ovf store disks. This patch changes it to break in that case, avoiding the inifinte loop. The issue existed since the relevant code was introduced, it was exposed by https://bugzilla.redhat.com/1412547 which made it occur frequently. This patch makes the minimal change to solve the issue as it's going to be backported to the stable branch, more refactors will be made on the master branch. Change-Id: I8669fc6a14879456116fb95ea23737f1ff6672a3 Bug-Url: https://bugzilla.redhat.com/1424755 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/72996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8669fc6a14879456116fb95ea23737f1ff6672a3 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>