Change in ovirt-engine[master]: core: Cleanup VmPoolCommandBase#isVmFree
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Cleanup VmPoolCommandBase#isVmFree
......................................................................
core: Cleanup VmPoolCommandBase#isVmFree
Cleaned up VmPoolCommandBase's isVmFree method to make it more readable:
1. Adopted an early-return paradigm
2. Removed redundant null checks on messages. This method is only called
from canAttachNonPrestartedVmToUser, which always passes a new
ArrayList instance.
Change-Id: I2e59cd811d7c318674587df877d29a10d8ef220f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
1 file changed, 59 insertions(+), 68 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e59cd811d7c318674587df877d29a10d8ef220f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>