Arik Hadas has submitted this change and it was merged. Change subject: core: Auto select correct graphics device on Template creation ...................................................................... core: Auto select correct graphics device on Template creation The treatment performed in AddVmCommand initilization was missing from AddVmTemplateCommand. Moved the method to VmHandler and called both from AddVmCommand and AddVmTemplateCommand. Also when importing to ppc cluster another bug manifested itself with auto selection of soundcard. Since soundcard is not supported on ppc the null default value passed in parameters was not overwritten and caused NPE in later command execution. Now we set the soundcard explicitly to false if it remains null after the treatment. Change-Id: I66a4b8175f13511df2ed95cff5893522a18a9e4b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1341639 Signed-off-by: Martin Betak <mbetak@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java 4 files changed, 67 insertions(+), 42 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66a4b8175f13511df2ed95cff5893522a18a9e4b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra@redhat.com> Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>