Change in ovirt-engine[master]: core: ImportVm cleanup: iterate maps values()
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImportVm cleanup: iterate maps values()
......................................................................
core: ImportVm cleanup: iterate maps values()
Iterate of VM's disks map values() instead of iterating over the
keySet() and using get() to retrieve the value when the key is not
interesting.
The main purpose for this change is the added readability, and the
(slight) performance gain is just a bonus.
Change-Id: I687810d5619603aab135a7d5d8e8fcef11685e9a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 9 insertions(+), 11 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9616
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I687810d5619603aab135a7d5d8e8fcef11685e9a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>