Ondra Machacek has submitted this change and it was merged.
Change subject: Name plular element tag same as the member
......................................................................
Name plular element tag same as the member
Previously when we send action and contruct XML with
list of the entity we named tags by the entity. This
patch changes the behavior, so we name it by the member
which is written.
For example if we want to create bonds, we will send following xml:
<action>
<modified_bonds>
<host_nic>
<bonding>
<options>...</options>
<slaves>
<host_nic>
<name>eth0</name>
</host_nic>
<host_nic>
<name>eth1</name>
</host_nic>
</slaves>
</bonding>
<name>bond0</name>
</host_nic>
</modified_bonds>
</action>
Previously we sent <host_nics> instead of <modified_bonds>.
Change-Id: Id1405d540f95abc8dc9dcfa0ac3b2a477b4cba06
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
M sdk/tests/server.py
A sdk/tests/test_setupnetworks.py
3 files changed, 111 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/62445
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1405d540f95abc8dc9dcfa0ac3b2a477b4cba06
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>