Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateStorageDomain's CDA early return ...................................................................... core: UpdateStorageDomain's CDA early return Changed UpdateStorageDomainCommand.canDoAction() to use the early return pattern in order to solve several NullPointerExceptions and enhance readability. Tests were added to all the canDoAction() flows to make sure these changes did not break any functionality. Change-Id: Iea10984090a759ef07da1fe572c4fdc323ede0e5 Signed-off-by: Allon Mureinik <amureini@redhat.com> Signed-off-by: Idan Shaby <ishaby@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommandTest.java 2 files changed, 97 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/29809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea10984090a759ef07da1fe572c4fdc323ede0e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server