From Tal Nisan <tnisan@redhat.com>:
Tal Nisan has submitted this change and it was merged. Change subject: core: FenceVolumeJob - avoiding growing number of db records ...................................................................... core: FenceVolumeJob - avoiding growing number of db records FenceVolumeJob is executed in order to fence operations that were submitted and are supposed to be performed on the volume. In case of failure to fence an operation, the engine may attempt to fence it again - when the fencing fails constantly the number of commands will grow till the flow ends. As we store a record for each command in the commands table that's something should be prevented. The engine uses the command record just for polling (to avoid executing another fence operation before the previous one ended) and not for determining if the fencing succeeded (it polls the entity to verify that), therefore we are fine with deleting the command entity after the execution ends. Change-Id: I62659c3840ce4bc46f7846751d45b779f3606279 Bug-Url: https://bugzilla.redhat.com/1440549 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/FenceVolumeJobCommand.java 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/75474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62659c3840ce4bc46f7846751d45b779f3606279 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>