Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix VM pop-up Host tab ...................................................................... webadmin: Fix VM pop-up Host tab In the VM pop-up view, host tab - the logic of the UI visibility and availability is wrong. CPU pinning topology textbox should always be visible. Both 'Use Host CPU' and 'CPU Pinning topology' are unavailable for clusters with compatibility version under 3.2. Logic of the flags 'Use Host CPU' and 'CPU Pinning topology' should be as follows: A = 'cpu pinning' available B = 'use host cpu' available For RHEV: Any Selected Host Host ------------------------------------------------------------- Allow auto migration Allow Man. migration B Do not allow migration B A+B For oVirt: Any Selected Host Host ------------------------------------------------------------- Allow auto migration A Allow Man. migration B A Do not allow migration B A+B Change-Id: Ibe691e0292a6bf99521629f04d292698ba1027e5 Bug-Url: https://bugzilla.redhat.com/905831 Signed-off-by: Ofri Masad <omasad@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 4 files changed, 38 insertions(+), 22 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe691e0292a6bf99521629f04d292698ba1027e5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: ofri masad <omasad@redhat.com>