Change in ovirt-engine[master]: backend: Fix incorrect allocation of Host Devices
Omer Frenkel has submitted this change and it was merged.
Change subject: backend: Fix incorrect allocation of Host Devices
......................................................................
backend: Fix incorrect allocation of Host Devices
It was possible for the MarkHostDevicesUsedByVmId to accidentally allocate same
host device on multiple hosts if there existed such host devices in DB. This
patch adds the host id to the stored procedure parameter to ensure the
allocation is only performed on given host's devices.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1250363
Change-Id: I390452251e33b487a5d815c71d8a29958ff23db8
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDao.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java
M packaging/dbscripts/host_device_sp.sql
6 files changed, 12 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44364
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I390452251e33b487a5d815c71d8a29958ff23db8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org