Change in ovirt-engine[master]: webadmin: unescape cell tooltips string values
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: unescape cell tooltips string values
......................................................................
webadmin: unescape cell tooltips string values
SafeHtmlCellWithTooltip -> getTooltip:
Unescaping title's text value to prevent tooltips
with escaped characters/html tags (unrendered)
[it should be safe since browsers natively render
title attributes as string].
Example screenshots:
* escaped (current) - http://imgur.com/8aNIouV
unescaped - http://imgur.com/nQFP0jx
* escaped (current) - http://imgur.com/9HxHA4H
unescaped - http://imgur.com/8wzOUVE
Change-Id: I2da6812694737c212352afda48fa9a50e97f8d60
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1001851
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlCellWithTooltip.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java
2 files changed, 16 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2da6812694737c212352afda48fa9a50e97f8d60
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server