Change in ovirt-engine[ovirt-engine-3.4]: tools: notifier: implement and use transport.idle().
Itamar Heim has submitted this change and it was merged.
Change subject: tools: notifier: implement and use transport.idle().
......................................................................
tools: notifier: implement and use transport.idle().
As part of transitioning to more then one Transport,
It is no longer possible to let a transport sleep
and retry for as long as it wants. that might
starve other transports especially in a short
notification interval.
Retrying transports (those that can detect sending failures)
Should implement a queue and attempt to send it on idle.
This patch also fixes a bug where smtp loging is done
only before the first send attempt.
Change-Id: I8c4bafb542d28cb584e0751446d3e327f93e8112
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1051492
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/Transport.java
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
A
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/ShutdownHook.java
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
8 files changed, 209 insertions(+), 110 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/24706
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c4bafb542d28cb584e0751446d3e327f93e8112
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server