From Allon Mureinik <amureini@redhat.com>:
Allon Mureinik has submitted this change and it was merged. Change subject: core: NumberOfMonitorsConstraint null checks ...................................................................... core: NumberOfMonitorsConstraint null checks The ValidNumOfMonitors config value should always be present. If it isn't, there's a problem with the installation, and the code should error out instead of silently failing the validation. This patch removes the wrong null check on the config value's result. With this check eliminated, the code can be slightly optimized to avoid retrieving the config value if the passed value was null. Change-Id: Ib5a74c917336cdc0d60b7559abb20710f8d123e9 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NumberOfMonitorsConstraint.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5a74c917336cdc0d60b7559abb20710f8d123e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>