Oved Ourfali has submitted this change and it was merged.
Change subject: core: Allow updating wipeAfterDelete for an UP VM
......................................................................
core: Allow updating wipeAfterDelete for an UP VM
The wipeAfterDelete property simply determines how the VM's volumes
should be treated when they are deleted, and has no effect on how the VM
is run.
There is no reason to disallow updating them when the VM is running.
Change-Id: I8fcb93ab0e45798745e2e5accc2d851b6df00d6d
Bug-Url:
http://bugzilla.redhat.com/1103679
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
2 files changed, 22 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit
http://gerrit.ovirt.org/28588
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fcb93ab0e45798745e2e5accc2d851b6df00d6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server