Allon Mureinik has submitted this change and it was merged. Change subject: core: Reuse ImportValidator in ImportVmTemplate ...................................................................... core: Reuse ImportValidator in ImportVmTemplate [Re]use ImportValidator instead of copy pasting the same code between it and ImportVmTemplateCommand There a VERY slight performance benefit here too, as it saves the compilation of the same regex in two places instead of just one. Change-Id: I2e351dca07e21211dda36c83f7b4bbd03c168868 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java 1 file changed, 2 insertions(+), 45 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e351dca07e21211dda36c83f7b4bbd03c168868 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>