Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: new VM guide dialog does not get updated
......................................................................
webadmin: new VM guide dialog does not get updated
The "There are still unconfigured entities" is present
after adding a new disk.
The problem was that the postAction and resetData were
not called from the NewDiskModel.
This was partially implemented for the network interfaces
by the NewGuideVmInterfaceModel - it just was not used.
Fixed by creating the NewGuideDiskModel which works the same way as the network
one and also to use the NewGuideVmInterfaceModel.
Change-Id: I7f6c38cdc316b8f9b3501e04980d7cb2e3908136
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1005846
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewGuideDiskModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
3 files changed, 28 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/19040
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f6c38cdc316b8f9b3501e04980d7cb2e3908136
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server