Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: allow SSO robots to fill in the login ...
Oved Ourfali has submitted this change and it was merged.
Change subject: userportal, webadmin: allow SSO robots to fill in the login form
......................................................................
userportal, webadmin: allow SSO robots to fill in the login form
Our UI editors/models don't get populated from forms unless a change event fires on
the form (usually on blur when a user types in a value and tabs away from that field
(ValueChangeEvent)).
For the login form, there are third-party SSO applications that "paste"
credentials
into the form. LastPass, for example, works fine because it fires a DOM change event
on the fields it pastes into. But here are other solutions that don't fire that
change event after pasting into the fields.
We want to allow those to work by forcing change events on the form fields
when the form is submitted. This patch does just that. Now when the login form
is submitted, "change" is fired on the username, password, and profile fields,
which
causes the editor and model to be properly populated, which allows the login to
succeed.
Change-Id: I0364ac5c4524f5260480bca38642a6998d0c9147
Bug-Url: https://bugzilla.redhat.com/1194394
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPresenterWidget.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
3 files changed, 47 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38017
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0364ac5c4524f5260480bca38642a6998d0c9147
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server