Change in ovirt-engine[master]: webadmin: edit nic shouldn't raise error in case the lables ...
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: edit nic shouldn't raise error in case the lables
weren't changed
......................................................................
webadmin: edit nic shouldn't raise error in case the lables weren't changed
If a nic/bond contain unmanaged/unsync network, editing the nic's/bond's
dialog raised an error.
If just the VfsConfig section was changed, or no chages were made at all,
an error shouldn't be displayed.
Change-Id: Ie55b8b4fc42699d55a978cd076f0a397c9c74851
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/PfNicLabelModel.java
2 files changed, 46 insertions(+), 23 deletions(-)
Approvals:
Alona Kaplan: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37023
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie55b8b4fc42699d55a978cd076f0a397c9c74851
Gerrit-PatchSet: 36
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org