Change in ovirt-engine[master]: engine: clone VM from snapshot corrupts original VM
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: clone VM from snapshot corrupts original VM
......................................................................
engine: clone VM from snapshot corrupts original VM
The problem was in AddVmFromSnapshotCommand which calls
VmDeviceUtils.copyVmDevices which accepts the following params:
srcId, destId, destVm, destVmBase
but it was called with:
srcId, destId, srcVm, srcVmBase
In most cases the srcId and destId is used but in some cases
also the entities themselfs which caused to copy the devices
from source VM to itself which corrupted it.
This regression has been introduced by:
4864cbe79e63475216baf165d3ff8681769822c0
Change-Id: I60dddf57f7f2cf9ec8a3a429d97e84c3bbcc12b2
Bug-Url: https://bugzilla.redhat.com/982636
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17007
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60dddf57f7f2cf9ec8a3a429d97e84c3bbcc12b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server