Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in hibernate command ...................................................................... core: cleanup in hibernate command - rename _storageDomainId to cachedStorageDomainId and do not initialize it to Empty guid but use 'null' value instead - remove redundant reload of the VM in the 'perform' method, as the VM is already locked, thus no multi-requests for hibernation is possible - use getStoragePoolId instead of getVm().getStoragePoolId, since it is the same - rephrase the comment on getStorageDomainId method Change-Id: Ib714ea598fdd8da26ae077efc3298cd0861fb02f Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java 1 file changed, 93 insertions(+), 101 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/36883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib714ea598fdd8da26ae077efc3298cd0861fb02f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server