Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing perfomance issue between VdsRunTimeInfo and RunVmCommandBase ...................................................................... engine: Fixing perfomance issue between VdsRunTimeInfo and RunVmCommandBase After introducing atomic update, no need for special lock inside of RunVmCommandBase.decreasePendingVms() In order to keep functionality for delay: SynchronousQueue will be used. The thread will stuck until time out or some other thread will add some object to queue Change-Id: Ia6c6e26c79dc6c06c9621e1938ecd034e9ce7ec7 Signed-off-by: Michael Kublin <mkublin@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsMonitor.java 2 files changed, 21 insertions(+), 48 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6c6e26c79dc6c06c9621e1938ecd034e9ce7ec7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>