Eli Mesika has submitted this change and it was merged.
Change subject: core: enable <not equal> operator for tag search
......................................................................
core: enable <not equal> operator for tag search
This patch allows searching Tags with != operator.
Up to now, when "tag" is used in the search criteria, we had used
StringOnlyEqualConditionRelationAutoCompleter to validate the tag value,
this class allows only for "=" operator.
Actually, there is no reason for this limitation and we can safely
replace this class use with StringConditionRelationAutoCompleter that
allows both "=" and "!=" operators.
This makes StringOnlyEqualConditionRelationAutoCompleter unused and
therefor it was removed.
Change-Id: Icb8fd9c3f75a62841b8d89933c16ac2077c95e4d
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1092609
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
D
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StringOnlyEqualConditionRelationAutoCompleter.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdsConditionFieldAutoCompleter.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
4 files changed, 2 insertions(+), 19 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/28280
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb8fd9c3f75a62841b8d89933c16ac2077c95e4d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server