From Alexander Wels <awels@redhat.com>:
Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/79285 ) Change subject: webadmin: refactor enumeration localization bundles ...................................................................... webadmin: refactor enumeration localization bundles Refactored the Enums bundle to push all of its members/keys up to its parent LocalizedEnums. Anything defined only in Enums has not been translated since only LocalizedEnums is managed via Zanata. Now all enumerations translated via EnumTranslator can actually have the English messages translated. Change-Id: Ia0374320795aeaa32eb8c7a1dfa6d684a98608a6 Signed-off-by: Scott J Dickerson <sdickers@redhat.com> --- M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/junit/UiCommonSetup.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ConstantsManager.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java D frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 8 files changed, 995 insertions(+), 1,015 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/79285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0374320795aeaa32eb8c7a1dfa6d684a98608a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Scott Dickerson <sdickers@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>