Itamar Heim has submitted this change and it was merged. Change subject: engine: quota was not enforced in run VM ...................................................................... engine: quota was not enforced in run VM Since quota uses MLA model, each quota related action should add permission checks for Consume_Quota action group on the specified quota. this was not the case in Add VM and the command's derivatives (add VM from .., etc.). The reason for that was that the user can create a VM from template and select the template's quota. this quota should be available only if the user has consumption rights for this quota. Last issue is that when failing on no-permission of consume_quota, the err message shouldn't be: 'the user isn't author...' but more suitable one related to quota and consumption. Bug-Url: https://bugzilla.redhat.com/1020201 Change-Id: I053680e61b8f9a0557845d0b5359a022b6473052 Signed-off-by: Gilad Chaplik <gchaplik@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 14 insertions(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I053680e61b8f9a0557845d0b5359a022b6473052 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Itamar Heim <iheim@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server