Change in ovirt-engine[master]: core: Pull up close to IIrsServer
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Pull up close to IIrsServer
......................................................................
core: Pull up close to IIrsServer
JsonRpcIIrsServer already has a close() method, while IrsServerWrapper
does not, forcing IrsProxyData to use run time type recognition and
downcasting to understand how to shut its connection down.
This patch pulls up the close() method to the IIrsServer interface in
order to allow IrsProxyData to close it in a more Java-ish fashion.
As a side effect of this refactoring, the getHttpClient() can now be
removed (as it indeed was), as it's no longer needed externally. This
fact strengthens the conviction that adding the close() method was the
right thing to do, as now IrsServerWrapper no longer needs to expose its
internal implementation details beyond receiving an HttpClient instance
when its constructed.
Change-Id: Ia7335536bdcf1ec51b4e941f710f46994043172f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
4 files changed, 8 insertions(+), 10 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55744
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7335536bdcf1ec51b4e941f710f46994043172f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>