Change in ovirt-engine[master]: backend: Filter orphaned Host Devieces on refresh
Arik Hadas has submitted this change and it was merged.
Change subject: backend: Filter orphaned Host Devieces on refresh
......................................................................
backend: Filter orphaned Host Devieces on refresh
In some hotplug scenarios (especially those related to SCSI devices) it can
happen that libvirt reports to VDSM an internally inconsistent list of devices,
namely that the parent_device points to a device not in the list or is empty
altogether.
Those cases violate the DB constraint imposed on the host_device and cause the
RefreshHostDevicesCommand transaction to fail. Since those cases are impossible
to handle at lower layers and we need to maintain consistend view of the host
devices for our main business logic, we now ignore those invalid devices in the
hostdev refresh cycle.
Change-Id: I520d7b6cc7ef099da7b6a67381a7cdc8d2ae0e64
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1315100
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommandTest.java
2 files changed, 118 insertions(+), 4 deletions(-)
Approvals:
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Martin Betak: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60661
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I520d7b6cc7ef099da7b6a67381a7cdc8d2ae0e64
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>