Arik Hadas has submitted this change and it was merged. Change subject: core: send all graphics device attrs as specParams ...................................................................... core: send all graphics device attrs as specParams If Vdsm receives a graphic device, it doesn't look for global parameters, and checks only the device specParams. This patch makes sure we fill the specParams correctly, and that we don't send parameters in the global configuration anymore. This is safe because we already dropped compatibility with <= 3.4 Engines. Change-Id: I7fbde1568785228fc83fc5315a8491ca6d117692 Bug-Url: https://bugzilla.redhat.com/1331333 Backport-To: 3.6 Signed-off-by: Francesco Romani <fromani@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 3 files changed, 28 insertions(+), 38 deletions(-) Approvals: Francesco Romani: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fbde1568785228fc83fc5315a8491ca6d117692 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Francesco Romani <fromani@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>