Itamar Heim has submitted this change and it was merged.
Change subject: engine: Remove vNIC from external network when necessary
......................................................................
engine: Remove vNIC from external network when necessary
Removing the vNIC from the external network only when the vNIC is
removed or the VM gets somehow removed.
This will allow the user of the vNIC to manipulate it on the external
network and not lose his changes when the VM stops.
Change-Id: I027992f52c35add0afd1ffe207b1adbdb2c5c957
Bug-Url:
https://bugzilla.redhat.com/1013491
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java
8 files changed, 96 insertions(+), 52 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/20138
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I027992f52c35add0afd1ffe207b1adbdb2c5c957
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server