2:14 a.m.
Tal Nisan has submitted this change and it was merged.
Change subject: core, vdsbroker: Refresh volume after extension during Live Merge
......................................................................
core, vdsbroker: Refresh volume after extension during Live Merge
When merging a larger (extended) volume into a smaller base volume, the
ExtendImageSize command may be run on a different host than the Merge
command. In this case the host running Merge may be unaware of the size
change, resulting in a failure.
To prevent this, ExtendImageSize will now send a RefreshVolume request
if a base volume is extended. The refresh is done on all hosts with the
volume in use because they otherwise have no way of knowing about the
new size.
In addition, we will send a refresh request during live merge recovery
to allow recovery from a failure due to the above size discrepancy when
a merge is retried.
Change-Id: I043c7f14359d1befb3e442958760d2a0dc4c9882
Bug-Url: https://bugzilla.redhat.com/1291569
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshVolumeCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
A
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RefreshVolumeParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
A
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RefreshVolumeVDSCommandParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
A
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RefreshVolumeVDSCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
15 files changed, 306 insertions(+), 33 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Greg Padgett: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50470
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I043c7f14359d1befb3e442958760d2a0dc4c9882
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>