Change in ovirt-engine[master]: core: Add actual free memory to vds statistics
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Add actual free memory to vds statistics
......................................................................
core: Add actual free memory to vds statistics
currently, only memAvailable is exposed by vdsm to engine. But this api is a
calculated value and so it may return negative value in case ksm
is up and pages are shared among VMs. This causes wrong 'memory under
defined threshold' logs.
The new "memFree" returns the true free memory on the host.
i.e. 'MemFree' + 'Cached' + 'Buffers' (from meminfo)
Change-Id: I68bbee6cc3c43636c2059443d980a2ae4c639854
Bug-Url: https://bugzilla.redhat.com/977758
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java
M
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_03_0440_add_free_mem_to_vds_statistics.sql
M packaging/dbscripts/vds_sp.sql
10 files changed, 54 insertions(+), 11 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68bbee6cc3c43636c2059443d980a2ae4c639854
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>