Change in ovirt-engine[master]: sercon: servlet: make sure '\n' in key are handled
Omer Frenkel has submitted this change and it was merged.
Change subject: sercon: servlet: make sure '\n' in key are handled
......................................................................
sercon: servlet: make sure '\n' in key are handled
The SSH Public key should not include any newline.
They are harmless when stored into Engine, but
the should not be passed around to vmconsole.
This patch enforces this constraint in two way:
- split the strings by '\n', producing one entry per
item. This way, the user can piggyback more than
one key in the same field.
- trim each key item to make sure no '\n' is emitted.
Change-Id: I80caba7749337a48c060fd5afad5c30b2e46a65f
Bug-Url: https://bugzilla.redhat.com/1223671
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M
backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/VMConsoleProxyServlet.java
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46065
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80caba7749337a48c060fd5afad5c30b2e46a65f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org