Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix incorrect value of migrating_to_vds
......................................................................
core: fix incorrect value of migrating_to_vds
Since we retried to switch host to maintenance as part of the monitoring
thread but before the updated data from the monitoring was saved, the
migrating_to_vds could have been overridden and set back to its
previous value.
This bug caused NPE in VURTI#handOver method sometimes and sometimes it
produced a VM which is not migrating with some wrong value in its
migrating_to_vds field.
The solution is to retry to switch host to maintenance in the
after-refresh-treatment part of the monitoring.
Change-Id: I423d573ae5251d3058bdfb778a2b486ac5ea0090
Bug-Url:
https://bugzilla.redhat.com/1131856
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit
http://gerrit.ovirt.org/31749
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I423d573ae5251d3058bdfb778a2b486ac5ea0090
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server