Change in ovirt-engine[master]: core: change inner representation for tunnel migration
Omer Frenkel has submitted this change and it was merged.
Change subject: core: change inner representation for tunnel migration
......................................................................
core: change inner representation for tunnel migration
Findbugs complained about setting tunnel-migration to null, when it was
represented as Boolean. We used null value to indicate that the
'VdsProperties.TUNNELED' attribute should not be sent to VDSM (in order
to maintain backward compatibility).
This patch changes the representation of tunnel-migration from Boolean
to boolean, and in MigrateBrokerVDSCommand we check again if the
tunnel-migration feature is supported or not, and if it is not supported
then we don't send the 'VdsProperties.TUNNELED' to VDSM.
Change-Id: I9f1df36ec741f09f49a436854486d37c442fc042
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java
3 files changed, 17 insertions(+), 15 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f1df36ec741f09f49a436854486d37c442fc042
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server