Change in ovirt-engine[master]: core: misleading error when trying to fen(#843168)
Eli Mesika has submitted this change and it was merged.
Change subject: core: misleading error when trying to fen(#843168)
......................................................................
core: misleading error when trying to fen(#843168)
ovirt-engine-backend: misleading error when trying to fence host without
PM configured
https://bugzilla.redhat.com/843168
Problem was that the code in the canDoAction of the base class was not
adding any message if fencing is not configured in the host and also
retries the operation event though there is no chance that it will
succeed.
Changing the code to add a message when Start/Stop is called on a non
configured Host.
Make StopVdsCommand call the super.canDoAction in the same manner as
StartVdsCommand does.
Change-Id: I7aab4f6a7c70fa5e18db106ea15a7b20b709db28
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java
2 files changed, 10 insertions(+), 9 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7aab4f6a7c70fa5e18db106ea15a7b20b709db28
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server