Omer Frenkel has submitted this change and it was merged. Change subject: core: add missing null check on proceedBalloonCheck ...................................................................... core: add missing null check on proceedBalloonCheck When host has balloon enabled, and vm is not reported by vdsm, there is NPE in proceedBalloonCheck because vdsmVm is null. also log monitoring exceptions stack trace in error, these errors are important enough to be fully logged when happen. Change-Id: Ibc08dbb8e8448049b07bee5130a5654501df28fe Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252012 Signed-off-by: Omer Frenkel <ofrenkel@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 3 files changed, 16 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc08dbb8e8448049b07bee5130a5654501df28fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: automation@ovirt.org