From Allon Mureinik <amureini@redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/78854 ) Change subject: webadmin: SearchSuggestBox#showSuggestions NPE ...................................................................... webadmin: SearchSuggestBox#showSuggestions NPE suggestionPopup#showRelativeTo (eventually) dereferences the suggestBox that was passed to it. If it was null, a NullPointerException will be thrown. This patch moves this call inside the null check to avoid this potential NPE. Change-Id: I63b98b1626dc8f770be15eb7de100ddc0a384e23 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestBox.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63b98b1626dc8f770be15eb7de100ddc0a384e23 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>