Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Remove advanced parameters from vNIC dialog
......................................................................
webadmin: Remove advanced parameters from vNIC dialog
Since the port mirroring checkbox moved to the vNIC profile dialog,
the advanced parameters section in the vNIC dialog only includes
plug/unplug at the moment, rendering it quite unnecessary. Also
rearranged some of the widget declarations so hitting tab will move
between them in a more logical order.
Change-Id: Idc9e865f9f8c2fe371d3a33703ea1a8172fea8aa
Bug-Url:
https://bugzilla.redhat.com/1011999
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
2 files changed, 40 insertions(+), 54 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/20570
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc9e865f9f8c2fe371d3a33703ea1a8172fea8aa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server