Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StringCompatTest ...................................................................... core: Remove StringCompatTest StringCompatTest did not in fact test StringCompat (which was already removed), but StringHelper's join method. This method is already thoroughly tested in StringHelperTest, so this test is redundant and can be removed. Change-Id: I9fc6ec3759f661e4da54957a2140a4d975cf9546 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- D backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/StringCompatTest.java 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fc6ec3759f661e4da54957a2140a4d975cf9546 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>