From Tal Nisan <tnisan@redhat.com>:
Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Pass Discard is irrelevant for AttachDiskModel ...................................................................... webadmin: Pass Discard is irrelevant for AttachDiskModel AttachDiskModel is a sub class of AbstractDiskModel, and thus when events like storageDomain_SelectedItemChanged are raised in AttachDiskModel, updatePassDiscardAvailability and updatePassDiscardChangeability are called although Pass Discard is irrelevant for AttachDiskModel. This patch adds an empty override of these methods to AttachDiskModel to solve this problem. Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54 Bug-Url: https://bugzilla.redhat.com/1430754 Signed-off-by: Idan Shaby <ishaby@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/73924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>