Change in ovirt-engine[ovirt-engine-3.6]: webadmin: fix memory leak in alerts / events footer
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: fix memory leak in alerts / events footer
......................................................................
webadmin: fix memory leak in alerts / events footer
Fixed a large memory leak in alerts and events footer.
Each table has a 'dismiss' column and cell. The cells
were holding references to ModelProviders, which created
a circular reference. These tables also update every 5
seconds, so that was a ton of DOM nodes that were
detached and not GC-able.
Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33
Bug-Url: https://bugzilla.redhat.com/1294678
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractImageButtonCell.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/AlertListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java
5 files changed, 54 insertions(+), 42 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55555
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>