Change in ovirt-engine[master]: engine: Fixing compensation for RemoveVmTemplateCommand and ...
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Fixing compensation for RemoveVmTemplateCommand and possible other
commands
......................................................................
engine: Fixing compensation for RemoveVmTemplateCommand and possible other commands
So, the fix is simple - change name.
After a restart of engine - RemoveVmTemplate command is created based on parameters,
but with old name vmTemplateId did not pass json serialization and get default value -
Guid.Empty,
which is id of blank template.
After that , we are trying to delete blank template and failed (We are lucky) - means
command failed, a origin template left
with status Locked
Change-Id: Ifb042d6cb8276a3c457a94823e90c1e6936cfa69
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb042d6cb8276a3c457a94823e90c1e6936cfa69
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>