Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Small refactoring to simplify VnicProfileModel
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Small refactoring to simplify VnicProfileModel
......................................................................
webadmin: Small refactoring to simplify VnicProfileModel
It wasn't really clear what exactly dcId and dcCompatibilityVersion
were affecting, whereas customPropertiesVisible was passed around as a
parameter when it really should only be set when the VnicProfileModel
is constructed.
Also theoretically improved the behavior of selecting a QoS
configuration from the list. Currently when editing a network the DC
can't be changed, but if that is enabled in the future, then if the DC
will be switched and then switched back, the original QoS selection
will be salvaged.
Change-Id: I8e98a1fc26ce6b32076e09a67e6a3d82f52964df
Bug-Url: https://bugzilla.redhat.com/1023952
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
2 files changed, 29 insertions(+), 22 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21032
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e98a1fc26ce6b32076e09a67e6a3d82f52964df
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server