Change in ovirt-engine[master]: findbugs: convert to double on integer values before casting...
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: convert to double on integer values before casting them
......................................................................
findbugs: convert to double on integer values before casting them
Doing division on integers truncates the result to the integer value
closest to zero.
ICAST: integral division result cast to double or float (ICAST_IDIV_CAST_TO_DOUBLE)
Change-Id: I3f3aa3ccef90c2cc63d5192d892eadb054254def
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/IntegerSlider.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SliderBar.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f3aa3ccef90c2cc63d5192d892eadb054254def
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server